Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(enqueueLinks): prevent useless request creations when filtering by user patterns #1510

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix(enqueueLinks): prevent useless request creations when filtering by user patterns #1510

merged 1 commit into from
Aug 31, 2022

Conversation

vladfrangu
Copy link
Member

Closes #1490

@metalwarrior665
Copy link
Member

Funny that we want to change this to AND so we will need to remove the break anyway but this order of iteration is just clearer

@vladfrangu
Copy link
Member Author

We won't need to remove the break here for #1509 as its a different method that does the filtering 👀

@vladfrangu vladfrangu changed the title fix(enqueueLinks): prevent useless request creations when filtering fix(enqueueLinks): prevent useless request creations when filtering by user patterns Aug 31, 2022
@vladfrangu vladfrangu merged commit cb8fe36 into master Aug 31, 2022
@vladfrangu vladfrangu deleted the fix/1490 branch August 31, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalwarrior665 metalwarrior665 metalwarrior665 approved these changes

@B4nan B4nan Awaiting requested review from B4nan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inefficient iteration in enqueueLinks
2 participants
@vladfrangu @metalwarrior665